-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented Genetics in blueberry bush. #57
Conversation
Checked it out real quick and it looks fine, although it is indeed a bit hard to test. Maybe you can think of a debug console command or two to help it out, or some sort of seed examiner item? It would also help if the UI had a bit more of an indication of what it does. Rather than 4 boxes in a row try to add some minimal decoration so maybe it ends up looking like: [] + [] -> [][] |
I added a command |
@xrtariq2594 mind doing a bit of general testing for SimpleFarming then merge this? I can confirm the seed mixer works, but didn't test anything in general (like if seeds with or without mixing actually grow, etc) |
I spoke with @arpan98 and he came up with a general testing guide for this PR. Thought it might be helpful if I sent it here.
|
|
||
//A=5, F=10, K=15 | ||
GeneMutator geneMutator = new VocabularyGeneMutator("ABCDEFGHIJK"); | ||
BreedingAlgorithm breedingAlgorithm = new MonoploidBreedingAlgorithm(0, 0.05f, geneMutator); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest you make the mutation chance (the 0.05f parameter here) a separate variable. That would increase readability and would also make it easier to tweak.
Maybe add a second variant of the blueberry with a different genome? Would make testing a lot easier (won't have to wait for random mutations to see genome changes). |
Hey, so because of the recent refactor to this module, I think we might need to rework this whole PR. Adding more commits onto this PR will just make it messy, so I think we should close this one and create a new one. We should still be able to salvage large portions of the code. |
I also think that the Hunger stuff isn't the feature we would want to add first, as it involves adding a dependency to Hunger, which we may or may not want to do (ping @jellysnake. Maybe we should move part of this to EdibleFlora?). I would say we should start off with things like flower/bush color or something simple with two possible varieties (one dominant, one recessive). |
Sorry for coming back to this only now 🙈 I'm closing this due to date and conflicts. |
Feature for #46 .
Relies on the changes made in the Genome module in this PR: Terasology/Genome#7.
Implemented a genetic system including mutation and breeding from the Genome module into SimpleFarming. Currently implemented only for blueberry, varying the Food filling component.
Might be a little difficult to test due to only one character gene (mutation is the only thing that matters), so try increasing the mutation rate.
Things to do further: